Eric Anholt <eric at anholt.net> writes:
I've pushed a patch responding to these comments to my dri3 branch and
will send that out shortly. I will merge those changes with the original
DRI3+Present loader patch so that there is only one commit when the
review process is complete.
> I think I'm going to be griping about code duplication...
Yeah, I'm really not sure what to do about that. The alternative would
be to refactor the DRI2 backend and then land the DRI3 backend on top of
some shared code, but frankly I'm not that excited about breaking DRI2.
Do you want me to actually go ahead and try to do that?
> Patches need to land in XCB and get released before this can land. I
> don't even see patches on the xcb list yet.
I sent out the patches to the xorg-devel list today after reworking and
cleaning them up. I'd forgotten that there was a separate xcb list.
>> +
>> +#define DRIVER_MAP_DRI3_ONLY
>
> What does this define do?
It is designed to be used in case there are two drivers for a chipset,
one DRI2 one and one DRI3 one. Much like the DRIVER_MAP_GALLIUM_ONLY
flag. It's not currently being used at all, so it should probably just
get removed until necessary.
> '{' on a separate line, please.
Fixed.
> This looks completely like dri2_create_context, except for missing
> rendertype validation and a different calloc size.
Yup. It's cult-n-paste. Note that the license at the top of the file
tries to make it clear that *lots* of the code in this file was copied
