On 05/15/2013 09:58 AM, Alex Deucher wrote: > On Wed, May 15, 2013 at 8:35 AM, Kleber Sacilotto de Souza > <klebers at linux.vnet.ibm.com> wrote: >> On 05/06/2013 11:32 AM, Alex Deucher wrote: >>> >>> On Fri, May 3, 2013 at 7:01 PM, Benjamin Herrenschmidt >>> <benh at kernel.crashing.org> wrote: >>>> >>>> On Fri, 2013-05-03 at 19:43 -0300, Kleber Sacilotto de Souza wrote: >>>> >>>>> This patch series does: >>>>> 1. max_bus_speed is used to set the device to gen2 speeds >>>>> 2. on power there's no longer a conflict between the pseries call and >>>>> other >>>>> architectures, because the overwrite is done via a ppc_md hook >>>>> 3. radeon is using bus->max_bus_speed instead of >>>>> drm_pcie_get_speed_cap_mask >>>>> for gen2 capability detection >>>>> >>>>> The first patch consists of some architecture changes, such as adding a >>>>> hook on >>>>> powerpc for pci_root_bridge_prepare, so that pseries will initialize it >>>>> to a >>>>> function, while all other architectures get a NULL pointer. So that >>>>> whenever >>>>> pci_create_root_bus is called, we'll get max_bus_speed properly setup >>>>> from >>>>> OpenFirmware. >>>>> >>>>> The second patch consists of simple radeon changes not to call >>>>> drm_get_pcie_speed_cap_mask anymore. I assume that on x86 machines, >>>>> the max_bus_speed property will be properly set already. >>>> >>>> >>>> So I'm ok with the approach now and I might even put the powerpc patch >>>> in for 3.10 since arguably we are fixing a nasty bug (uninitialized >>>> max_bus_speed). >>>> >>>> David, what's your feeling about the radeon change ? It would be nice if >>>> that could go in soon for various distro targets :-) On the other hand >>>> I'm not going to be pushy if you are not comfortable with it. >>> >>> >>> FWIW, the radeon change looks fine to me. >>> >>> Alex >>> >> >> Hi David, >> >> Are you planning to accept the radeon patch? If yes, can we still expect it >> to make it for 3.10? >> >> As Ben mentioned, we have some distro targets to make and it would be nice >> to have an outlook of the upstream acceptance to start the conversations >> with those distros. > > Is the rest of this series already upstream? I don't see a problem > pulling it in if the rest of the patches are in Dave's tree. Dave, do > you want to grab this, or do you wan me to pull it in through my tree? > > Alex >
The powerpc patch was applied by Ben and is already upstream. Thanks, -- Kleber Sacilotto de Souza IBM Linux Technology Center
