On Thu, Feb 28, 2013 at 04:43:06PM -0800, John Stultz wrote: > From: Erik Gilling <konkers at android.com> > > This is needed to allow modules to link against the sync subsystem > > Cc: Maarten Lankhorst <maarten.lankhorst at canonical.com> > Cc: Erik Gilling <konkers at android.com> > Cc: Daniel Vetter <daniel.vetter at ffwll.ch> > Cc: Rob Clark <robclark at gmail.com> > Cc: Sumit Semwal <sumit.semwal at linaro.org> > Cc: Greg KH <gregkh at linuxfoundation.org> > Cc: dri-devel at lists.freedesktop.org > Cc: Android Kernel Team <kernel-team at android.com> > Signed-off-by: Erik Gilling <konkers at android.com> > Signed-off-by: John Stultz <john.stultz at linaro.org> > --- > drivers/staging/android/sync.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c > index 54f84d9..6739a84 100644 > --- a/drivers/staging/android/sync.c > +++ b/drivers/staging/android/sync.c > @@ -15,6 +15,7 @@ > */ > > #include <linux/debugfs.h> > +#include <linux/export.h> > #include <linux/file.h> > #include <linux/fs.h> > #include <linux/kernel.h> > @@ -64,6 +65,7 @@ struct sync_timeline *sync_timeline_create(const struct > sync_timeline_ops *ops, > > return obj; > } > +EXPORT_SYMBOL(sync_timeline_create);
As these are now global, should they be a bit more "specific"? "sync_" seems pretty broad. Also, EXPORT_SYMBOL_GPL() perhaps? And who is using these exports? thanks, greg k-h
