Hi Thierry, On Tuesday 03 December 2013 10:59:24 Thierry Reding wrote: > On Mon, Dec 02, 2013 at 01:52:20AM +0100, Laurent Pinchart wrote: > [...] > > > diff --git a/drivers/gpu/drm/shmobile/shmob_drm_crtc.c > > b/drivers/gpu/drm/shmobile/shmob_drm_crtc.c > [...] > > > @@ -170,7 +178,9 @@ static void shmob_drm_crtc_start(struct shmob_drm_crtc > > *scrtc) > > return; > > > > /* Enable clocks before accessing the hardware. */ > > - shmob_drm_clk_on(sdev); > > + ret = shmob_drm_clk_on(sdev); > > + if (ret < 0) > > + return; > > Perhaps this should be printing an error or using WARN_ON()? Otherwise > it might be very difficult to diagnose what's going wrong.
That's a good point. In practice, as the driver always uses a Renesas SoC MSTP clock, the clock code will print a message to the kernel log though, so I'm not sure whether we should duplicate that here. If you think we should I'll submit a new patch. -- Regards, Laurent Pinchart -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 490 bytes Desc: This is a digitally signed message part. URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20131204/041078b0/attachment.pgp>
