Am 21.04.2013 23:53, schrieb Alex Deucher: > On Fri, Apr 19, 2013 at 1:01 PM, Rafa? Mi?ecki <zajec5 at gmail.com> wrote: >> Some devices (ATI/AMD cards) don't support passing ELD struct to the >> hardware but just require filling specific registers and then the >> hardware/firmware does the rest. In such cases we need to read the info >> from SAD blocks and put them in the correct registers. >> >> Signed-off-by: Rafa? Mi?ecki <zajec5 at gmail.com> > Thanks both patches applied. I added a comment about needing to kfree > the returned pointer as per Christian's comment.
Found one more minor nitpick in this patch: > + if (cea_db_tag(db) == AUDIO_BLOCK) { > + dbl = cea_db_payload_len(db); > + int j; > + That's code after declaration and so complained on by the compiler. Christian.