On Thu, Sep 13, 2012 at 2:37 PM, Alex Deucher <alexdeucher at gmail.com> wrote: > On Thu, Sep 13, 2012 at 2:17 PM, Jerome Glisse <j.glisse at gmail.com> wrote: >> On Thu, Sep 13, 2012 at 10:13 AM, Dmitry Cherkasov >> <dcherkassov at gmail.com> wrote: >>> PDE/PTE update code uses CP ring for memory writes. >>> All page table entries are preallocated for now in alloc_pt(). >>> >>> It is made as whole because it's hard to divide it to several patches >>> that compile and doesn't break anything being applied separately. >>> >>> Tested on cayman card. >>> >>> Signed-off-by: Dmitry Cherkasov <Dmitrii.Cherkasov at amd.com> >>> --- >>> I couldn't test in on SI card, so would be happy if someone could check it >>> there. >> >> I wonder how this could have work as you don't set >> PAGE_TABLE_BLOCK_SIZE field so each page directory entry cover only 1 >> page. > > I think PAGE_TABLE_BLOCK_SIZE refers number of 4k pages used for PTE > entries per PDE. E.g., 1 4k page contains 512 64 bit PTEs. so if > BLOCK_SIZE is set to 1 page, each PDE points to 1 page (4k) or PTE > entries. If BLOCK_SIZE is 2, each PDE points to 2 pages (8k) or PTEs, > etc. > > Alex >
If so then it's ok Cheers, Jerome
