On Thu, Mar 29, 2012 at 18:28, Paulo Zanoni <przanoni at gmail.com> wrote:
> From: Paulo Zanoni <paulo.r.zanoni at intel.com> > > In the future we'll have more than just connector properties, so create > a dump_prop function that can handle any property (instead of the > current dump_props function that only handles connector properties). > > Also, make this function print a lot more information about the existing > properties. > > Also change the printed indentation of the modes to make the output more > readable. > <really-small-bikeshedding> I don't know if it should go into a separate patch though. But it is aligned to the other formatting patterns you do, and it certainly looks nicer this way, and it shouldn't break anything anyway. So I am fine either way :). </really-small-bikeshedding> > > The previous function dump_props also segfaulted when we didn't have > enought permissions. The new function does not segfault in this case (by > checking for the return value of drmModeGetProperty). > <another-bikeshedding> I think this could be done in a separate patch.. </another-bikeshedding> But besides those comments, this is: Reviewed-by: Eugeni Dodonov <eugeni.dodonov at intel.com> -- Eugeni Dodonov <http://eugeni.dodonov.net/> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20120329/9a487b5b/attachment.html>
