Hi,
Some minor commants.
On 07/06/2012 09:28 PM, Leela Krishna Amudala wrote:
> From: Prathyush K <prathyush.k at samsung.com>
>
> The name of the exynos drm fimd device is renamed to exynos-drm-fimd
> and two ids are created for exynos4-fb and exynos5-fb.
Please write the subject clearly this patch is to do what.
How about "add platform_device_id table for exynos5 fimd"?
>
> Signed-off-by: Prathyush K <prathyush.k at samsung.com>
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> index 37769cf..f7bb0a0 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> @@ -1092,6 +1092,16 @@ static const struct of_device_id drm_fimd_dt_match[] =
> {
> MODULE_DEVICE_TABLE(of, drm_fimd_dt_match);
> #endif
>
> +static struct platform_device_id exynos_drm_driver_ids[] = {
Use fimd_ prefix, such as "fimd_driver_ids".
> + {
> + .name = "exynos4-fb",
> + }, {
> + .name = "exynos5-fb",
> + },
> + {},
> +};
> +MODULE_DEVICE_TABLE(platform, exynos_drm_driver_ids);
> +
> static const struct dev_pm_ops fimd_pm_ops = {
> SET_SYSTEM_SLEEP_PM_OPS(fimd_suspend, fimd_resume)
> SET_RUNTIME_PM_OPS(fimd_runtime_suspend, fimd_runtime_resume, NULL)
> @@ -1100,8 +1110,9 @@ static const struct dev_pm_ops fimd_pm_ops = {
> struct platform_driver fimd_driver = {
> .probe = fimd_probe,
> .remove = __devexit_p(fimd_remove),
> + .id_table = exynos_drm_driver_ids,
> .driver = {
> - .name = "exynos4-fb",
> + .name = "exynos-drm-fimd",
> .owner = THIS_MODULE,
> .pm = &fimd_pm_ops,
> .of_match_table = of_match_ptr(drm_fimd_dt_match),
Thanks.
