Thank's for comment. Oops, sorry that is my fault. I will resend it.
BR Eunchul Kim On 12/20/2012 06:48 PM, Inki Dae wrote: > > >> -----Original Message----- >> From: Eunchul Kim [mailto:chulspro.kim at samsung.com] >> Sent: Thursday, December 20, 2012 6:32 PM >> To: dri-devel at lists.freedesktop.org; inki.dae at samsung.com >> Cc: jy0.jeon at samsung.com; yj44.cho at samsung.com; jmock.shin at >> samsung.com; >> jaejoon.seo at samsung.com; kyungmin.park at samsung.com; >> jy0922.shim at samsung.com; sw0312.kim at samsung.com; th908.kim at >> samsung.com; >> lsmin.lee at samsung.com; chulspro.kim at samsung.com >> Subject: [PATCH 3/8] drm/exynos: fixed vflip, hflip case at the same time. >> >> This patch fixed vflip, hflip at the same time. If we want to change 180 >> degree about buffer, >> then we can use h,vflip or 180 degree. we supports 180 degree using >> h,vflip. >> but we make error handling in this case. so, fixed it. >> >> Signed-off-by: Eunchul Kim <chulspro.kim at samsung.com> >> --- >> drivers/gpu/drm/exynos/exynos_drm_fimc.c | 1 + >> drivers/gpu/drm/exynos/exynos_drm_rotator.c | 1 + >> 2 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c >> b/drivers/gpu/drm/exynos/exynos_drm_fimc.c >> index 5dc0251..4c4078c 100644 >> --- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c >> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c >> @@ -1387,6 +1387,7 @@ static inline bool fimc_check_drm_flip(enum >> drm_exynos_flip flip) >> case EXYNOS_DRM_FLIP_NONE: >> case EXYNOS_DRM_FLIP_VERTICAL: >> case EXYNOS_DRM_FLIP_HORIZONTAL: >> + case EXYNOS_DRM_FLIP_VERTICAL | EXYNOS_DRM_FLIP_HORIZONTAL: > > This code induces build warning because the value of 'VERTICAL | HORIZONTAL' > is out of range. Add a new enumeration value to enum drm_exynos_flip. i.e. > EXYNOS_DRM_FLIP_BOTH = EXYNOS_DRM_FLIP_VERTICAL | EXYNOS_DRM_FLIP_HORIZONTAL > and use it. - thank's I guess why not occured warnning. but It's the better. I will resend it. > >> return true; >> default: >> DRM_DEBUG_KMS("%s:invalid flip\n", __func__); >> diff --git a/drivers/gpu/drm/exynos/exynos_drm_rotator.c >> b/drivers/gpu/drm/exynos/exynos_drm_rotator.c >> index 17e4474..09830ad 100644 >> --- a/drivers/gpu/drm/exynos/exynos_drm_rotator.c >> +++ b/drivers/gpu/drm/exynos/exynos_drm_rotator.c >> @@ -513,6 +513,7 @@ static inline bool rotator_check_drm_flip(enum >> drm_exynos_flip flip) >> case EXYNOS_DRM_FLIP_NONE: >> case EXYNOS_DRM_FLIP_VERTICAL: >> case EXYNOS_DRM_FLIP_HORIZONTAL: >> + case EXYNOS_DRM_FLIP_VERTICAL | EXYNOS_DRM_FLIP_HORIZONTAL: > > Ditto. > >> return true; >> default: >> DRM_DEBUG_KMS("%s:invalid flip\n", __func__); >> -- >> 1.7.0.4 > >
