On Fri, 07 Dec 2012, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> On Fri, 07 Dec 2012 13:47:46 +0200, Jani Nikula <jani.nikula at
> linux.intel.com> wrote:
>>
>> On Thu, 06 Dec 2012, Tim Gardner <tim.gardner at canonical.com> wrote:
>> > + if (!saved_mode) {
>> > + pr_err("i915: Could not allocate saved display mode.\n");
>>
>> Please use DRM_ERROR().
>
> Truthfully neither, but join the growing petition to get real errorcodes
> back to userspace!
Heh, agreed, but in the mean time (i.e. before hell freezes over) I
think we should prefer DRM_ERROR over pr_err for consistency.
Jani.
