Hi,

>What's with the #ifdef 0 or #ifdef 1?

>Why is there a bunch of ddkxxx something? Can those header files be squashed 
>together?

We have deleted all the "#ifdef 0 or #ifdef 1" and cut our codes into smaller 
parts in order to get reviewed easier. There are less ddkxxx something in this 
patch.

Subject: [PATCH] siliconmotion kernel driver initial patch

This is the initial patch for siliconmotion kernel driver. It can support SM750 
and SM718. It is a framebuffer driver.

Signed-off-by: Aaron Chen <aaron.chen at siliconmotion.com>
---
 drivers/video/Kconfig                 |   13 +
 drivers/video/Makefile                |    1 +
 drivers/video/lynxfb/Makefile         |   63 ++
 drivers/video/lynxfb/ddk750.h         |   31 +
 drivers/video/lynxfb/ddk750_chip.c    |  586 ++++++++++++
 drivers/video/lynxfb/ddk750_chip.h    |   97 ++
 drivers/video/lynxfb/ddk750_display.c |  295 ++++++
 drivers/video/lynxfb/ddk750_display.h |  124 +++
 drivers/video/lynxfb/ddk750_dvi.c     |  114 +++
 drivers/video/lynxfb/ddk750_dvi.h     |   84 ++
 drivers/video/lynxfb/ddk750_help.c    |   37 +
 drivers/video/lynxfb/ddk750_help.h    |   42 +
 drivers/video/lynxfb/ddk750_hwi2c.c   |  290 ++++++
 drivers/video/lynxfb/ddk750_hwi2c.h   |   28 +
 drivers/video/lynxfb/ddk750_mode.c    |  213 +++++
 drivers/video/lynxfb/ddk750_mode.h    |   59 ++
 drivers/video/lynxfb/ddk750_power.c   |  243 +++++
 drivers/video/lynxfb/ddk750_power.h   |   85 ++
 drivers/video/lynxfb/ddk750_reg.h     |  362 +++++++
 drivers/video/lynxfb/ddk750_sii164.c  |  435 +++++++++
 drivers/video/lynxfb/ddk750_sii164.h  |  187 ++++
 drivers/video/lynxfb/ddk750_swi2c.c   |  522 ++++++++++
 drivers/video/lynxfb/ddk750_swi2c.h   |   98 ++
 drivers/video/lynxfb/lynx_accel.c     |  417 ++++++++
 drivers/video/lynxfb/lynx_accel.h     |  161 ++++
 drivers/video/lynxfb/lynx_cursor.c    |  223 +++++
 drivers/video/lynxfb/lynx_cursor.h    |   36 +
 drivers/video/lynxfb/lynx_drv.c       | 1688 +++++++++++++++++++++++++++++++++
 drivers/video/lynxfb/lynx_drv.h       |  271 ++++++
 drivers/video/lynxfb/lynx_help.h      |  115 +++
 drivers/video/lynxfb/lynx_hw750.c     |  633 +++++++++++++
 drivers/video/lynxfb/lynx_hw750.h     |  120 +++
 drivers/video/lynxfb/modedb.c         |  238 +++++
 drivers/video/lynxfb/ver.h            |   38 +
 34 files changed, 7949 insertions(+)


Aaron

-----????-----
???: Konrad Rzeszutek Wilk [mailto:konrad.wilk at oracle.com] 
????: 2012?8?14? 2:03
???: Aaron.Chen ???
??: linux-fbdev at vger.kernel.org; mill.chen ??; Mandy.Wang ???; Paul.Chen ??; 
dri-devel at lists.freedesktop.org; caesar.qiu ???; Sunny.Yang ??
??: Re: ??: Siliconmotion new kernel driver initial patch

On Mon, Aug 13, 2012 at 04:56:33PM +0800, Aaron.Chen  ??? wrote:
> 
> Since there is no response for the last mail. Maybe it didn't sent 
> successfully. So I send it again. Here is the initial patch for siliconmotion 
> kernel driver.

What's with the #ifdef 0 or #ifdef 1?

Why is there a bunch of ddkxxx something? Can those header files be squashed 
together?
> 
> Aaron
> 


> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-siliconmotion-kernel-driver-initial-patch.patch
Type: application/octet-stream
Size: 256220 bytes
Desc: 0001-siliconmotion-kernel-driver-initial-patch.patch
URL: 
<http://lists.freedesktop.org/archives/dri-devel/attachments/20120824/b9303d69/attachment-0001.obj>

Reply via email to