On Thu, Apr 26, 2012 at 9:36 AM, Jerome Glisse <j.glisse at gmail.com> wrote: > 2012/4/26 David Airlie <airlied at redhat.com>: >> >> >> ----- Original Message ----- >>> From: "Christian K?nig" <deathsimple at vodafone.de> >>> To: "j glisse" <j.glisse at gmail.com> >>> Cc: "Jerome Glisse" <jglisse at redhat.com>, dri-devel at >>> lists.freedesktop.org >>> Sent: Thursday, 26 April, 2012 10:11:12 AM >>> Subject: Re: [PATCH 01/24] drm/radeon: remove fence/ring/ib debugfs files >>> >>> Hi Jerome, >>> >>> I totally agree that we can remove the following debugfs files, since >>> everything that just prints out or modifies register informations >>> doesn't belongs into the kernel driver and should be moved to >>> radeontool >>> instead. >> >> In the future with secure boot we will need a better mechanism to diagnose >> things >> than a userspace tool mapping pci bars, which we can't allow to happen in a >> secure >> boot environment, so dropping all the files might not be a good idea unless >> we >> provide a mechanism for radeontool to use. We can't allow userspace to >> read/write >> arbitrary registers and stay secure. >> >> Dave. > > Well those files are useless, each time i debug a lockup and try to > use them i loose > time on them as they never helped me so far and i seriously doubt they > would help > me in the future or anyone else. > > For secure boot my guess is that radeontool will become obsolete and > by that time > we might need to add some reg dumping. But none of the current files > seems usefull > to me.
We can always expose the mmio bar (and vbios for that matter) via ioctl or sysfs for radeontool. We should try and write a better unified tool suite. Alex > > The fence and sa files might make sense to debug the associated code > as it's nice > to be able to dump associated kernel struct. > > Cheers, > Jerome > _______________________________________________ > dri-devel mailing list > dri-devel at lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel
