Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] fbdev: xilinxfb: stale CONFIG_FB_XILINX in microblaze mmu_defconfig --
commit dc9c5a7ca88a79ff63fa682655927a4c3e97e183 Author: Radhey Shyam Pandey <[email protected]> fbdev: xilinxfb: remove the driver This commit removes the obsolete xilinxfb framebuffer driver along with its Kconfig option and Makefile entry. > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > index e8cd8cb76874b..50673b83cb857 100644 > --- a/drivers/video/fbdev/Kconfig > +++ b/drivers/video/fbdev/Kconfig > @@ -1620,15 +1620,6 @@ config FB_PS3_DEFAULT_SIZE_M > The default value can be overridden on the kernel command line > using the "ps3fb" option (e.g. "ps3fb=9M"); > > -config FB_XILINX > - tristate "Xilinx frame buffer support" > - depends on FB && (MICROBLAZE || ARCH_ZYNQ || ARCH_ZYNQMP) > - select FB_IOMEM_HELPERS > - help > - Include support for the Xilinx ML300/ML403 reference design > - framebuffer. ML300 carries a 640*480 LCD display on the board, > - ML403 uses a standard DB15 VGA connector. > - > config FB_GOLDFISH > tristate "Goldfish Framebuffer" > depends on FB [Severity: Low] Should CONFIG_FB_XILINX=y also be removed from arch/microblaze/configs/mmu_defconfig? Leaving it there triggers an unknown symbol warning when configuring mmu_defconfig with W=c. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
