On 04-Nov-26 18:41, Jeff Hugo wrote:
On 11/4/2026 1:29 AM, Karol Wachowski wrote:
Some generations support only 128 SSIDs, while the KMD configured 256
CD table entries and allowed user contexts up to SSID 130. Align the
limit across all generations.
When I read this, I have the question, why limit to 128 for all
generations when I assume some generations support more than 128. Would
that not be a handicap for users on the gen(s) which can utilize more?
It seems like the justification for applying this lowest common
denominator across everything is not quite clear to an outsider.
Limit the CD table to 128 entries and the user SSID range to 2-127, so
root can create 126 contexts and non-root users 64. Also fix the off by
one SSID bounds checks against the CD table size.
Hi,
The commit message could have been clearer. Before this patch the driver
allowed 128 user contexts (MIN_SSID + 128). Now the limit is 128 SSIDs
in total, which leaves 126 user contexts.
So the real cost is 2 contexts for root. Non-root stays at 64.
In return the SSID range, the CD table size and the bounds checks all
match. Testing gets simpler, because we can check exact limits instead
of loose minimums. The userspace interface also becomes consistent, with
the same limits everywhere.
I'll add this to the commit message in v2.
Thanks,
Karol
Signed-off-by: Karol Wachowski <[email protected]>
