On Tue, 03 Nov 2026 08:02:37 +0000, Wentao Liang wrote:
> oa_get_render_ctx_id() pins the context before obtaining its hardware ID.
> With GuC submission, gen12_get_render_context_id() can fail while
> allocating or accessing the scratch buffer used to read that ID. The
> error is returned without releasing the context pin.
>
> i915_oa_stream_init() immediately returns this error, and its caller
> frees the stream without invoking the stream destroy callback. There is
> therefore no later opportunity to release the pin.
>
> Unpin and clear pinned_ctx before returning this error. Also clear the
> pointer on the existing context-control-offset error path, so failed
> initialization consistently leaves no pinned context in the stream.
>
> Fixes: 682aa4373f15 ("drm/i915/perf: Fix OA filtering logic for GuC mode")
> Cc: [email protected]
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <[email protected]>
> ---
> drivers/gpu/drm/i915/i915_perf.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
Multiple things here:
1. Your team ignored completely previous feedback. Multiple times.
2. You use multiple identities with this email address, thus I doubt that we
speak with an actual person.
3. Your bot does not even bother running checkpatch, right?
4. Nothing of this was reproduced nor tested.
5. Finally, the same feedback:
You sent multiple independent patches, to multiple independent
subsystems. The amount of these patches clearly suggest this was
AI generated and most likely not tested.
More importantly, you sent all this work without properly organizing
relevant patches into patchsets. This makes reviewing difficult
and might cause multiple reviewers to address the same issue.
Replying to the entire set is impossible and requires handling each
patch independently, instead of applying or discarding the set.
Maintainers also won't see the bigger picture of your work. Quite
worrying.
This is on the verge of hostile patch: bomb us with so many
contributions, we won't be able to handle them in efficient manner,
like responding ONCE to ask you to slow down. Considering all this
is untested and LLM generated, I have even more doubts whether this
should be considered for review.
Please read kernel documentation BEFORE posting more work. It will
explain you how to identify subsystems, how to organize your work per
subsystem (so a patchset grouping multiple patches with a short cover
letter), how to document the issue discovery method and what was
or was not tested.
Best regards,
Krzysztof
