Am Sonntag, 1. November 2026, 09:23:00 Mitteleuropäische Normalzeit schrieb Jiaxing Hu: > The RK3576 NPU MMUs are rk3568-iommu compatible but take five clocks > instead of two. Give them their own compatible and pin both clock counts in > allOf. > > Signed-off-by: Jiaxing Hu <[email protected]> > Acked-by: Conor Dooley <[email protected]> > --- > .../bindings/iommu/rockchip,iommu.yaml | 28 +++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml > b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml > index 6ce41d11ff5e..83d7e7c8e0c2 100644 > --- a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml > +++ b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml > @@ -26,6 +26,7 @@ properties: > - items: > - enum: > - rockchip,rk3576-iommu > + - rockchip,rk3576-npu-iommu > - rockchip,rk3588-iommu > - const: rockchip,rk3568-iommu > > @@ -42,14 +43,22 @@ properties: > minItems: 1 > > clocks: > + minItems: 2 > items: > - description: Core clock > - description: Interface clock > + - description: Compute clock > + - description: Convolution buffer core clock > + - description: Convolution buffer interface clock > > clock-names: > + minItems: 2 > items: > - const: aclk > - const: iface > + - const: npu > + - const: aclk_cbuf > + - const: hclk_cbuf
I'd really like more justification in the commit message, why these additional clocks are needed. Not saying this is wrong, just should get a bit more explanation. Heiko
