Thank you for your contribution! Sashiko AI review found 1 potential issue(s)
to consider:
- [Low] drm/imx: dc: commit message mismatch for
dc_drv_set_crtc_{enable,disable}()
--
commit 1bad6b1819c8236cf47f95cfccc89fe8559ef3c8
Author: Liu Ying <[email protected]>
drm/imx: dc: Flag CRTC status in GENERALPURPOSE register
This commit maps the Display Controller's GENERALPURPOSE register via an
MMIO regmap and adds helpers to set, clear, and query the CRTC enablement
status bits.
> drm/imx: dc: Flag CRTC status in GENERALPURPOSE register
>
> Map Display Controller's register GENERALPURPOSE at offset 0x100 and
> create an MMIO regmap to access the register. Create helpers
> dc_drv_flag_crtc_{enable,disable}() with the 2 LSB bits in the register
> to flag the CRTC enablement/disablement status. Also, create a helper
> dc_drv_crtc_is_enabled() so that the CRTC driver can use it to check
> if the CRTC is enabled by a previous boot or not. This is a preparation
> for an upcoming patch to disable display controller at boot if the CRTC
> was enabled by the driver during a previous boot instead of a bootloader.
>
> Reviewed-by: Laurentiu Palcu <[email protected]>
> Signed-off-by: Liu Ying <[email protected]>
[Severity: Low]
As reported by Sashiko on v8 [1], the commit message states that helpers
dc_drv_flag_crtc_{enable,disable}() are created, whereas
drivers/gpu/drm/imx/dc/dc-drv.c and drivers/gpu/drm/imx/dc/dc-drv.h define
and declare dc_drv_set_crtc_enable() and dc_drv_set_crtc_disable(). Should
the commit message be updated to reference
dc_drv_set_crtc_{enable,disable}()?
[1] https://lore.kernel.org/r/[email protected]
--
Sashiko AI review ยท
https://sashiko.dev/#/patchset/[email protected]?part=6
