On Mon, Nov 02, 2026 at 03:26:42PM +0000, Hugo Sales wrote: > On 11/02/2026 12:05 PM WET Ville Syrjälä <[email protected]> > wrote: > > On Sat, Oct 31, 2026 at 04:19:52PM +0000, Hugo Sales wrote: > > > amdgpu walks connector->modes from its atomic_check, in > > > > That is just wrong. connector->modes is protected by mode_config.mutex > > You're right, I should have fixed the real issue rather than work around > it. Please drop this one > > I'll try to fix it in amdgpu instead. atomic_check can't take > mode_config.mutex there, so amdgpu would pick the mode it needs while > probing and keep its own copy, like it already does for freesync_vid_base
Yeah, that should be doable. > > > And regardless of changing the locking rules or not, someone > > should probably sprinkle lockdep asserts to bunch of places > > where connector->modes is consulted. Perhaps even introduce > > custom list iterator macros that include the assert... > > Makes sense. amdgpu would trip them today, so I'll look at that once > the amdgpu side is fixed Sounds good. -- Ville Syrjälä Intel
