Re: [PATCH v3 11/12] arm64: dts: qcom: sm6350-lena: Add PM6150L thermals

[erebion]

On 11/2/26 01:35, erebion wrote:

On 11/2/26 00:44, sashiko-...@kernel.org wrote:

[Severity: Medium]
Should rear_cam_sensor reference ADC5_GPIO2_100K_PU instead of
ADC5_GPIO6_100K_PU here?

On PM6150L, physical pin gpio6 is routed to ADC5_GPIO2_100K_PU (0x53), and under &pm6150l_adc below the rear camera thermistor channel is defined as:

Will fix with v4...

Ah yes, looks like I confused gpio6 from downstream DT and gpio2 from include/dt-bindings/iio/qcom,spmi-vadc.h

root@mobian:~# cat /sys/class/thermal/thermal_zone38/temp
-40000
root@mobian:~# cat /sys/class/thermal/thermal_zone38/type
rear-cam-thermal

Well, this does not look right either. I swear I don't live in Antarctica.


>> Should rear_cam_sensor reference ADC5_GPIO2_100K_PU instead of
>> ADC5_GPIO6_100K_PU here?

GPIO6: Value looks sensible at just over 30 °C
GPIO2: -40 °C



--
erebion

XMPP: ereb...@erebion.eu

My languages: German, English, Swedish, Norwegian, Danish

Perhaps GPIO6 was right after all or it is wrong while GPIO2 is wrong as well. Yes, I'm a language nerd. Feel free to write to me in any of the aforementioned languages.

OpenPGP_signature.asc
Description: OpenPGP digital signature