> > > I believe the issue couple of us observed was unexpected value in > > > check_boot_failure > > > called from xe_survivability_mode_is_requested. But as we went back up > > > the stack we > > > had absolutey zero indication there was any error. nothing indicated we > > > were even > > > in survivability mode. At least in that failure point case. > > > > > > I understand we have injected sigid code logging in the various other > > > branches > > > of downstream logic (from xe_device_probe_early->xe_pcode_probe_early / > > > xe_survivability_mode_is_requested), however, I it would be more intuitive > > > to put a single message at that top level to at least indicate some kind > > > of > > > survivability activity was directed, attempted and > > > entered-or-failed-to-enter > > > > > > If you believe the correct fix should be to ONLY keep error logs at every > > > subbranch instead at the top level, thats fine with me too too but i > > > notice > > > they currently don't actually convey the survivability state. > > > We have messages like "Firmware flash required" or "Boot mode enabled" > > > but nothing saying we are in survivability and the gpu isnt usable. > > From what I found both success and fail cases are logged here. > > > > if (check_boot_failure(xe)) > > xe_log_err_fatal(pdev, SURVIVABILITY, 0, "Boot Mode > > enabled!\n"); > > else > > xe_log_info(pdev, SURVIVABILITY, "Boot Mode enabled!\n"); > > > > These logs use SURVIVABILITY as a component which would appear in dmesg > > (not a fan of it myself, but that's unfortunately the xe_log design). alan: personal note - i think for these kinds of globally impacting event messages i think it makes sense to be present dmesg.
> > > > I do agree that we could log something like "Entering survivability mode" > > somewhere if xe_survivability_mode_is_requested() were to return true, > > unless Riana has a better idea. > > > If we are seeing a pcode init failure without boot status failed, then > that is a issue. > The only other way to enable this is via configfs. > > SIGID logs do print survivability > > <3>xe 0000:03:00.0: [drm] *ERROR* SIGID=103 FATAL SURVIVABILITY: Boot > Mode enabled! > > Agree with Raag here. We can remove this log from > enable_boot_survivability_mode > and add it in is_requested instead. > > Thanks > Riana > > > > > > Raag sounds good - will add single xe_log_info to _is_requested.
