On Thu, Oct 29, 2026 at 01:12:06PM +0000, Dmitry Ilvokhin wrote: > On Thu, Oct 29, 2026 at 02:00:28PM +0100, Miguel Ojeda wrote: > > On Thu, Oct 29, 2026 at 8:32 AM Thomas Zimmermann <[email protected]> > > wrote: > > > > > > Should gem.h now include <linux/compiler_attributes.h> ? > > > > No, it should be included for you (unless you are doing something > > custom with the compiler flags etc.). > > Just to add a bit more colour to Miguel's reply. > > I believe idea behind include/linux/compiler_attributes.h is to make > attribute wrappers as simple and transparent to use as native compiler > attributes. In particular, this means they should be available in every > kernel compilation unit without any additional effort. > > For this reason, all the nessesary plumbing is handled at the build > machinery level (see scripts/Makefile.lib:171), where '-include' > compiler flag is used to pull in include/linux/compiler_types.h, which > in turn pulls include/linux/compiler_attributes.h.
Ah, TIL! Please, discard my comment then. Perhaps we need to clean up all headers that pull compiler_types/compile_attributes directly (the same way we do for kconfig.h). -- With Best Regards, Andy Shevchenko
