On Fri, Oct 16, 2026 at 08:06:11PM +0200, Maarten Lankhorst wrote: > Hey, > > For the series: > Reviewed-by: Maarten Lankhorst <[email protected]>
Thanks for reviewing it > Would really love it if atomic_sro.[ch] is renamed to > atomic_state_readout.[ch], so > we have a better idea what it's about. :-) ACK > 2 things to note: > - Hardware readout may be succesful, but the resulting state may not be valid. > Think for example a crtc with a DP-MST connector, but the DP-MST connector > is not yet detected at time of readout. crtc_state is invalid because > connector_mask = 0. > > It would be awesome if DP-MST would be detected before this point. I'm not > sure this is > actually possible but it would make fastboot work on DP-MST as well. > > - Alternatively some hardware may be connected to the wrong plane. Older i915 > cards had a > flexible mapping of plane 1 being connected to crtc 1 or 2, but for optimal > performance you'd > want it to be plane 1 to crtc 2. BIOS chose plane 1 to crtc 1. In both cases, I think it should be up to drivers to report that the configuration doesn't make sense to them, and to fall back on a reset. I'll add it to the documentation. Thanks! Maxime
signature.asc
Description: PGP signature
