Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] drm/bridge: misplaced hdmi5_bridge_hpd_notify() hunk breaks bisection --
commit c49a65530348caef1493cae37ceadb5599e2733e Author: Dmitry Baryshkov <[email protected]> drm/bridge: pass extra events to the HPD callback This commit introduces drm_bridge_hpd_notify_extra() and updates the HPD callback signature registered via drm_bridge_hpd_enable() to pass extra DisplayPort sink events to underlying drivers. > diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5.c > b/drivers/gpu/drm/omapdrm/dss/hdmi5.c > index c542ba6ce7d32..a21f9355594cc 100644 > --- a/drivers/gpu/drm/omapdrm/dss/hdmi5.c > +++ b/drivers/gpu/drm/omapdrm/dss/hdmi5.c > @@ -427,7 +427,8 @@ static void hdmi5_bridge_disable(struct drm_bridge > *bridge, > > static void hdmi5_bridge_hpd_notify(struct drm_bridge *bridge, > struct drm_connector *connector, > - enum drm_connector_status status) > + enum drm_connector_status status, > + enum drm_connector_dp_event event) > { > struct omap_hdmi *hdmi = drm_bridge_to_hdmi(bridge); > [Severity: Low] Should this change to hdmi5_bridge_hpd_notify() in drivers/gpu/drm/omapdrm/dss/hdmi5.c be squashed into the preceding commit 8fdca4f38003 ("drm/bridge: pass down IRQ_HPD to the drivers") instead? hdmi5_bridge_hpd_notify() is assigned to struct drm_bridge_funcs.hpd_notify in hdmi5_bridge_funcs rather than passed to drm_bridge_hpd_enable(): drivers/gpu/drm/omapdrm/dss/hdmi5.c: static const struct drm_bridge_funcs hdmi5_bridge_funcs = { ... .hpd_notify = hdmi5_bridge_hpd_notify, }; Because struct drm_bridge_funcs.hpd_notify in include/drm/drm_bridge.h was updated to take the enum drm_connector_dp_event parameter in commit 8fdca4f38003 (alongside hdmi4_bridge_hpd_notify()), leaving the hdmi5_bridge_hpd_notify() update until this commit causes an incompatible function pointer type build failure at commit 8fdca4f38003 when building drivers/gpu/drm/omapdrm/dss/hdmi5.c, breaking bisection. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=4
