Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] dt-bindings: display: ssd1683: bare solomon,ssd1677 compatible without panel --
commit 99bb2813cd624693670923f366680d97f3d2c796 Author: Devarsh Thakkar <[email protected]> dt-bindings: display: solomon,ssd16xx: Add Solomon SSD1677 controller This commit adds solomon,ssd1677 as a compatible string to the Solomon SSD1683 e-paper display binding. > diff --git a/Documentation/devicetree/bindings/display/solomon,ssd1683.yaml > b/Documentation/devicetree/bindings/display/solomon,ssd1683.yaml > index 2e2aa195fb1e6..df8d9ff821a78 100644 > --- a/Documentation/devicetree/bindings/display/solomon,ssd1683.yaml > +++ b/Documentation/devicetree/bindings/display/solomon,ssd1683.yaml > @@ -31,6 +31,7 @@ properties: > # Good Display 4.2" 400x300 monochrome e-paper panel > - gooddisplay,gdey042t81 > - const: solomon,ssd1683 > + - const: solomon,ssd1677 > > reg: > maxItems: 1 [Severity: Medium] Should solomon,ssd1677 be used as a fallback behind a panel-specific compatible in an items list rather than as a standalone const? The SSD1677 is a display controller IC that supports panels of varying resolutions (up to 960x680 pixels), physical dimensions, booster soft-start tunings, and color configurations. Because this binding does not define Device Tree properties for panel resolution, timings, or color mode, panel parameters must be determined by a specific panel compatible string (just as gooddisplay,gdey042t81 is paired with solomon,ssd1683 above, and as ssd16xx_of_match in drivers/gpu/drm/solomon/ssd16xx.c expects when ssd16xx_probe() looks up ssd16xx_device_configs[model]). Defining solomon,ssd1677 as a standalone const under properties:compatible allows a bare compatible = "solomon,ssd1677" node that lacks panel geometry and cannot bind to the driver, while rejecting valid two-entry panel-plus-controller compatible tuples during dtbs_check validation. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=3
