Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Low] dts: build failure due to missing k1-power.h dt-binding header - [Low] dts: undocumented compatible strings for spacemit k1-gpu --
commit 8e44783c41b2ae5db8c6c7e6e7e39b06ba8d49af Author: Iker Pedrosa <[email protected]> riscv: dts: spacemit: k1: add PowerVR GPU device node Add device tree node for the Imagination Technologies PowerVR Rogue GPU (BVNC 36.29.52.182 / BXE-2-32) found in the Spacemit K1 SoC. > diff --git a/arch/riscv/boot/dts/spacemit/k1.dtsi > b/arch/riscv/boot/dts/spacemit/k1.dtsi > index 3fabfd34114b2..82cade2f76fe4 100644 > --- a/arch/riscv/boot/dts/spacemit/k1.dtsi > +++ b/arch/riscv/boot/dts/spacemit/k1.dtsi > @@ -5,6 +5,7 @@ > > #include <dt-bindings/clock/spacemit,k1-syscon.h> > #include <dt-bindings/phy/phy.h> > +#include <dt-bindings/power/spacemit,k1-power.h> [Severity: Low] Does this header exist in the tree? It doesn't appear to be added in this patch or in the tree yet, which causes a fatal preprocessor error and compilation failure. [ ... ] > @@ -1119,6 +1120,17 @@ multimedia-bus { > #size-cells = <2>; > dma-ranges = <0x0 0x00000000 0x0 0x00000000 0x0 > 0x80000000>, > <0x0 0x80000000 0x1 0x00000000 0x3 > 0x80000000>; > + > + gpu: gpu@cac00000 { > + compatible = "spacemit,k1-gpu", > "img,img-bxe-2-32", "img,img-rogue"; [Severity: Low] Are these compatible strings documented in a DT binding schema? "spacemit,k1-gpu" and "img,img-bxe-2-32" appear to be undocumented, which will cause dt_binding_check to fail. Omitting them from the schema also means their constraints (like required clocks or power domains) won't be properly validated. > + reg = <0x0 0xcac00000 0x0 0x80000>; > + interrupts = <75>; > + clocks = <&syscon_apmu CLK_GPU>; > + clock-names = "core"; > + resets = <&syscon_apmu RESET_GPU>; > + power-domains = <&syscon_apmu K1_PMDOMAIN_GPU>; [Severity: Low] Is it possible to build this node? This relies on K1_PMDOMAIN_GPU which was presumably provided by the missing spacemit,k1-power.h header mentioned above. > + status = "disabled"; > + }; > }; -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
