On Wed, Oct 14, 2026 at 07:27:30PM +0200, Maxime Ripard wrote: > The malidp writeback connector reset implementation creates a custom > state subclass, but only initializes a pristine state without resetting > any hardware. This is equivalent to what atomic_create_state expects. > Convert to it. > > Signed-off-by: Maxime Ripard <[email protected]>
Reviewed-by: Liviu Dudau <[email protected]> Best regards, Liviu > --- > Cc: Liviu Dudau <[email protected]> > --- > drivers/gpu/drm/arm/malidp_mw.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/arm/malidp_mw.c b/drivers/gpu/drm/arm/malidp_mw.c > index f8be65119e3b..edd924ba722d 100644 > --- a/drivers/gpu/drm/arm/malidp_mw.c > +++ b/drivers/gpu/drm/arm/malidp_mw.c > @@ -62,22 +62,22 @@ malidp_mw_connector_mode_valid(struct drm_connector > *connector, > static const struct drm_connector_helper_funcs > malidp_mw_connector_helper_funcs = { > .get_modes = malidp_mw_connector_get_modes, > .mode_valid = malidp_mw_connector_mode_valid, > }; > > -static void malidp_mw_connector_reset(struct drm_connector *connector) > +static struct drm_connector_state * > +malidp_mw_connector_create_state(struct drm_connector *connector) > { > - struct malidp_mw_connector_state *mw_state = kzalloc_obj(*mw_state); > + struct malidp_mw_connector_state *mw_state; > > - if (connector->state) > - __drm_atomic_helper_connector_destroy_state(connector->state); > + mw_state = kzalloc_obj(*mw_state); > + if (!mw_state) > + return ERR_PTR(-ENOMEM); > > - kfree(connector->state); > - connector->state = NULL; > + __drm_atomic_helper_connector_state_init(&mw_state->base, connector); > > - if (mw_state) > - __drm_atomic_helper_connector_reset(connector, &mw_state->base); > + return &mw_state->base; > } > > static enum drm_connector_status > malidp_mw_connector_detect(struct drm_connector *connector, bool force) > { > @@ -109,11 +109,11 @@ malidp_mw_connector_duplicate_state(struct > drm_connector *connector) > > return &mw_state->base; > } > > static const struct drm_connector_funcs malidp_mw_connector_funcs = { > - .reset = malidp_mw_connector_reset, > + .atomic_create_state = malidp_mw_connector_create_state, > .detect = malidp_mw_connector_detect, > .fill_modes = drm_helper_probe_single_connector_modes, > .destroy = malidp_mw_connector_destroy, > .atomic_duplicate_state = malidp_mw_connector_duplicate_state, > .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, > > -- > 2.55.0 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯
