On 10/7/26 10:45 PM, Rob Herring wrote:
> On Wed, Oct 07, 2026 at 03:51:18PM +0530, Ekansh Gupta wrote:
>> The reg value of a compute-cb node must match the SID (the lower
>> nibble of its IOMMU stream ID) it is associated with. In the cdsp
>> fastrpc node, compute-cb@10, compute-cb@11 and compute-cb@12 were
>> mistakenly given reg values of 10, 11 and 12 instead of 12, 13 and
>> 14, which don't match their SIDs and leads to SMMU translation errors.
>> Fix the reg values, and rename the nodes accordingly.
>>
>> Fixes: cd1d174c75f7 ("arm64: dts: qcom: glymur: Add ADSP and CDSP for Glymur 
>> SoC")
>> Co-developed-by: Mahima Bhattaram <[email protected]>
>> Signed-off-by: Mahima Bhattaram <[email protected]>
>> Reviewed-by: Pankaj Patil <[email protected]>
>> Reviewed-by: Abel Vesa <[email protected]>
>> Reviewed-by: Mukesh Ojha <[email protected]>
>> Signed-off-by: Ekansh Gupta <[email protected]>
>> ---
>>  arch/arm64/boot/dts/qcom/glymur.dtsi | 12 ++++++------
>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi 
>> b/arch/arm64/boot/dts/qcom/glymur.dtsi
>> index de7c395d9c35..3219603372ce 100644
>> --- a/arch/arm64/boot/dts/qcom/glymur.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi
>> @@ -8471,9 +8471,9 @@ compute-cb@8 {
>>  
>>                                      /* note: compute-cb@9 is secure */
>>  
>> -                                    compute-cb@10 {
>> +                                    compute-cb@c {
>>                                              compatible = 
>> "qcom,fastrpc-compute-cb";
>> -                                            reg = <10>;
>> +                                            reg = <12>;
> 
> Normally, reg is written in hex too.

+1 please do that

Konrad

Reply via email to