On Mon, 2026-10-12 at 09:05 +0100, Tvrtko Ursulin wrote:
> 
> On 08/10/2026 11:10, Philipp Stanner wrote:
> > On Fri, 2026-10-02 at 13:46 +0100, Tvrtko Ursulin wrote:
> > > Commit
> > > 0e118b936dc5 ("drm/sched: Lock drm_sched_entity_is_idle()")
> > > has removed the last unlocked entity->stopped access so lets officially
> > > document it in kerneldoc as locked with the entity lock.
> > 
> > Ah nice, I overlooked that. Thx for fixing.
> > 
> > Nit: typo in the commit title, "protectED". I can fix that at applying
> > if you want.
> 
> Ah yes, best not to spam the list for that. If you want I can push and 
> tweak as well.

fine by me

Acked-by: Philipp Stanner <[email protected]>

> 
> Tvrtko
> > > 
> > > Signed-off-by: Tvrtko Ursulin <[email protected]>
> > > Cc: Christian König <[email protected]>
> > > Cc: Danilo Krummrich <[email protected]>
> > > Cc: Matthew Brost <[email protected]>
> > > Cc: Philipp Stanner <[email protected]>
> > > ---
> > >   include/drm/gpu_scheduler.h | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h
> > > index 563d7fb88a6d..3b0978fa8cf0 100644
> > > --- a/include/drm/gpu_scheduler.h
> > > +++ b/include/drm/gpu_scheduler.h
> > > @@ -101,7 +101,7 @@ struct drm_sched_entity {
> > >            *
> > >            * Lock protecting the run-queue (@rq) to which this entity 
> > > belongs,
> > >            * @priority, @last_scheduled and the list of schedulers 
> > > (@sched_list,
> > > -  * @num_sched_list) and @rr_ts.
> > > +  * @num_sched_list), @rr_ts and @stopped.
> > >            */
> > >           spinlock_t                      lock;
> > >   

Reply via email to