Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] dt-bindings: undocumented compatible string dfrobot,unihiker-m10-display --
commit bb7cab2e48d73305c4348ab50dde38a500cc0a23 Author: Mizuno Miotsuki <[email protected]> arm64: dts: rockchip: Enable display on UNIHIKER M10 V1.2 Enable the onboard 240x320 SPI display using panel-mipi-dbi. Add its D/C and reset GPIOs, display timing, and PWM1 backlight, and enable SPI2 with a maximum transfer frequency of 50 MHz. > diff --git a/arch/arm64/boot/dts/rockchip/rk3308-unihiker-m10-v1.2.dts > b/arch/arm64/boot/dts/rockchip/rk3308-unihiker-m10-v1.2.dts > index 270ea970c95a7..a3264ef23746e 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3308-unihiker-m10-v1.2.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3308-unihiker-m10-v1.2.dts [ ... ] > @@ -211,6 +230,40 @@ &sdmmc { > status = "okay"; > }; > > +&spi2 { > + assigned-clocks = <&cru SCLK_SPI2>; > + assigned-clock-parents = <&cru PLL_DPLL>; > + assigned-clock-rates = <100000000>; > + status = "okay"; > + > + display@0 { > + compatible = "dfrobot,unihiker-m10-display", > "panel-mipi-dbi-spi"; [Severity: Low] Does the dfrobot,unihiker-m10-display compatible string need to be added to the corresponding YAML binding schema? Since it is used here without being documented in the panel-mipi-dbi-spi bindings, it might trigger validation warnings during make dtbs_check. > + reg = <0>; > + spi-max-frequency = <50000000>; > + pinctrl-names = "default"; -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=2
