Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] dt-bindings: missing schema definition for 'dfrobot,unihiker-m10-display' --
commit 6e141ce95f426918ca0341028cd073760d1b80d9 Author: Miotsuki Mizuno <[email protected]> arm64: dts: rockchip: Enable display on UNIHIKER M10 V1.2 This commit enables the onboard SPI display for the UNIHIKER M10 V1.2 board. It adds device tree nodes for the backlight, LCD control pins, and the SPI display itself along with its timing and required properties. > diff --git a/arch/arm64/boot/dts/rockchip/rk3308-unihiker-m10-v1.2.dts > b/arch/arm64/boot/dts/rockchip/rk3308-unihiker-m10-v1.2.dts > index 270ea970c95a7..a3264ef23746e 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3308-unihiker-m10-v1.2.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3308-unihiker-m10-v1.2.dts [ ... ] > @@ -211,6 +230,40 @@ &sdmmc { > status = "okay"; > }; > > +&spi2 { > + assigned-clocks = <&cru SCLK_SPI2>; > + assigned-clock-parents = <&cru PLL_DPLL>; > + assigned-clock-rates = <100000000>; > + status = "okay"; > + > + display@0 { > + compatible = "dfrobot,unihiker-m10-display", > "panel-mipi-dbi-spi"; [Severity: Low] Will make dtbs_check report a validation failure here? The panel-mipi-dbi-spi driver parses the first compatible string to construct the firmware filename, but the corresponding schema located at Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml enforces an explicit list of valid compatible strings via an enum. Since dfrobot,unihiker-m10-display does not appear to be added to the schema, does this violate the DT binding rules? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=2
