Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] dt-bindings: display: ti,tpd12s015: missing minItems: 3 for gpios --
commit d5e502558b023b930dba87dd54c3fb7121502833 Author: Chaosheng Qu <[email protected]> dt-bindings: display: ti,tpd12s015: Convert to DT schema Convert the TPD12S015 HDMI level shifter binding to DT schema, documenting the ports and compatible fallbacks. > diff --git a/Documentation/devicetree/bindings/display/ti/ti,tpd12s015.yaml > b/Documentation/devicetree/bindings/display/ti/ti,tpd12s015.yaml > new file mode 100644 > index 0000000000000..1927da3bd7361 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/ti/ti,tpd12s015.yaml [ ... ] > + gpios: > + description: > + The CT CP HPD, LS OE and HPD GPIOs, in that order. The first controls > + the level shifter, the second enables the level shifter outputs and > + the third reads the hot-plug detect line. > + maxItems: 3 [Severity: Low] Does this property need a minItems: 3 constraint? If a device tree developer omits the first two optional GPIOs without using <0> placeholders, the array will have fewer than 3 elements. This will pass YAML schema validation. However, the drivers handling this device (both ti-tpd12s015.c and encoder-tpd12s015.c) unconditionally request the HPD GPIO at index 2 using devm_gpiod_get_index(&pdev->dev, NULL, 2, GPIOD_IN). If the array has fewer than 3 elements, the driver probe will immediately fail at runtime with -ENOENT. Adding minItems: 3 would ensure the dt-schema validation catches incomplete arrays earlier. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
