Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] dt-bindings: vdd-supply validation dropped for visionox,vtdr6130 --
commit a3a48cee05612d79cd6eb27b26e83813b38aff64 Author: Aaron Kling <[email protected]> dt-bindings: display: visionox,vtdr6130: Add Retroid Pocket 6 panel The vtdr6130 is a display driver integrated circuit, a common chip used for various panels. One such panel is used in the Retroid Pocket 6. > diff --git > a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml > b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml > index c99f4146f1bb0..682f30dc9ee43 100644 > --- a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml > +++ b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml [ ... ] > @@ -25,13 +29,13 @@ properties: > vdd-supply: true > port: true > reset-gpios: true > + rotation: true > > required: > - compatible > - reg > - vddio-supply > - vci-supply > - - vdd-supply [Severity: Medium] By dropping vdd-supply globally from the required list, does this cause incomplete schema validation for the original visionox,vtdr6130 hardware? Device trees using compatible = "visionox,vtdr6130" might now erroneously omit the previously required vdd-supply property and silently pass schema validation. Should this be solved using an allOf and if-then block to conditionally require vdd-supply only for the original hardware? > - reset-gpios > - port > -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
