On Wed, Sep 16, 2026 at 08:54:44AM +0200, Thomas Zimmermann wrote: > Hi > > Am 15.09.26 um 16:24 schrieb Maxime Ripard: > > This is a follow-up to the plane reset removal series, and part of a > > larger effort to remove the reset hook from all KMS objects. > > > > The CRTC reset hook is overloaded: it is called both at probe time to > > create the initial software state and during suspend/resume to reset > > hardware and software state. These two roles have different > > requirements, and the reset hook is not fallible, making error > > handling difficult for the initial state allocation path. > > > > While reset has the semantics to reset both the software and hardware > > state, the vast majority of implementations and all the helpers only > > reset the software state, making them equivalent to > > atomic_create_state in practice. The atomic_create_state hook makes > > this explicit: it only allocates and initializes a pristine state > > without any side effect, and returns the state pointer or an ERR_PTR > > on failure. > > > > This series converts all CRTC drivers tree-wide from the reset hook to > > atomic_create_state, then removes the reset hook from struct > > drm_crtc_funcs entirely. Two drivers (tilcdc and loongson) had actual > > hardware reset logic mixed into their reset hook; those are moved to > > CRTC creation instead. The conversions were done using a combination of > > Coccinelle semantic patches and manual adjustments. > > > > Signed-off-by: Maxime Ripard <[email protected]> > > It might be my mail client but the formatting in patch 5 looks off. Besides > that, for the series: > > Reviewed-by: Thomas Zimmermann <[email protected]>
Thanks, I've fixed it while applying Maxime
signature.asc
Description: PGP signature
