On Tue, Sep 15, 2026 at 3:19 PM Bjorn Helgaas <[email protected]> wrote: > > > > On Fri, Jul 31, 2026 at 02:15:48PM -0700, Zhiping Zhang wrote: > > get_rp_completer_type() returns the Root Port's "TPH Completer > > Supported" field (bits 13:12 of Device Capabilities 2) verbatim. The > > 0b10 encoding is reserved, but pcie_enable_tph() feeds the raw value > > into the requester type: > > > > pdev->tph_req_type = min(pdev->tph_req_type, rp_req_type); > > > > and later writes tph_req_type to the TPH Requester Enable field, which > > only defines 0b00 (disable), 0b01 (TPH only) and 0b11 (extended TPH). > > > > No known hardware presents the reserved 0b10 in this field, so this is > > defensive hardening rather than a fix for observed silicon: fold the > > reserved encoding into "not supported" so only the three architected > > values can ever reach the Requester Enable field. > > > > Signed-off-by: Zhiping Zhang <[email protected]> > > Acked-by: Chengwen Feng <[email protected]> > > In subject, to match history of the file: > > PCI/TPH: Treat reserved 0b10 completer encoding as unsupported > > Acked-by: Bjorn Helgaas <[email protected]> >
Thanks Bjorn! I'll fix the subject to match the file's history and carry your Acked-by in v14, which will otherwise just be a rebase of v13 onto 7.3. Thanks, Zhiping
