On Tue, Sep 15, 2026 at 11:26:30AM +0200, Geert Uytterhoeven wrote: > Hi Maxime, > > > Bridges have some fields in their state worth printing, but we don't > > provide an atomic_print_state implementation to show those fields. > > > > Provide one. > > > > Reviewed-by: Laurent Pinchart <[email protected]> > > Signed-off-by: Maxime Ripard <[email protected]> > > Thanks for your patch, which is now commit 4a7a146f1cc6791a > ("drm/bridge: Implement atomic_print_state") in drm-misc/for-linux-next. > > > --- a/drivers/gpu/drm/drm_bridge.c > > +++ b/drivers/gpu/drm/drm_bridge.c > > @@ -548,14 +548,35 @@ drm_bridge_atomic_create_priv_state(struct > > drm_private_obj *obj) > > return ERR_CAST(state); > > > > return &state->base; > > } > > > > +static void > > +drm_bridge_atomic_print_priv_state(struct drm_printer *p, > > + const struct drm_private_state *s) > > +{ > > + const struct drm_bridge_state *state = drm_priv_to_bridge_state(s); > > warning: passing argument 1 of ‘drm_priv_to_bridge_state’ discards ‘const’ > qualifier from pointer target type [-Wdiscarded-qualifiers] > > Apparently you lost "[PATCH v2 4/28] drm/atomic: Convert > drm_priv_to_bridge_state to container_of_const"[1] along the way?
Yes, indeed. It should be fixed now, sorry Maxime
signature.asc
Description: PGP signature
