Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] dt-bindings: missing maxItems constraint for data-lanes --
commit 17bcf4f8b4142033bbe40bc85ad49b91b1b814ab Author: Pet Weng <[email protected]> dt-bindings: display: Add ITE IT61620 MIPI DSI to HDMI bridge This chip receives MIPI DSI input and outputs HDMI, and is commonly connected to SoCs via I2C and DSI. IT61620 uses a separate compatible string from IT6162 due to architectural differences. > diff --git > a/Documentation/devicetree/bindings/display/bridge/ite,it61620.yaml > b/Documentation/devicetree/bindings/display/bridge/ite,it61620.yaml > new file mode 100644 > index 0000000000000..d4f0edeecd0e2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/ite,it61620.yaml [ ... ] > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: Input port for MIPI DSI > + > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + required: > + - data-lanes [Severity: Low] Should this data-lanes property include a local constraint to enforce the hardware limit of 4 lanes? If a user configures a device tree with 5 to 8 lanes, it seems dt_binding_check will incorrectly accept it. The endpoint schema inherits the generic limit of 8 from video-interfaces.yaml without imposing the local hardware limit. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
