On 9/7/26 10:23, Uwe Kleine-König wrote: > Hello Michael, > > On Fri, Sep 04, 2026 at 03:27:12PM +0200, Michal Wilczynski wrote: >> +#include <linux/mod_devicetable.h> >> [...] >> +#include <linux/platform_device.h> > > Please don't add includes for <linux/mod_devicetable.h> as it introduces > many unneeded build dependencies. Either rely on > <linux/platform_device.h> providing of_device_id (IMHO preferred), or > include <linux/device-id/of.h> directly. > > The same applies to two more patches in this series. > > Best regards > Uwe Thank you for your review. This will be fixed for v4. Best regards, -- Michal Wilczynski <[email protected]>
- [PATCH v3 14/19] drm/bridge: starfive: Add JH7110 HDMI... Michal Wilczynski
- Re: [PATCH v3 14/19] drm/bridge: starfive: Add JH... sashiko-bot
- Re: [PATCH v3 14/19] drm/bridge: starfive: Add JH... Chaoyi Chen
- Re: [PATCH v3 14/19] drm/bridge: starfive: Ad... Michal Wilczynski
- Re: [PATCH v3 14/19] drm/bridge: starfive: Add JH... Michal Wilczynski
- [PATCH v3 11/19] soc: starfive: Add jh7110-hdmi-subsys... Michal Wilczynski
- Re: [PATCH v3 11/19] soc: starfive: Add jh7110-hd... sashiko-bot
- Re: [PATCH v3 11/19] soc: starfive: Add jh7110-hd... Uwe Kleine-König
- Re: [PATCH v3 11/19] soc: starfive: Add jh711... Michal Wilczynski
- [PATCH v3 18/19] riscv: dts: starfive: jh7110: Update ... Michal Wilczynski
- Re: [PATCH v3 18/19] riscv: dts: starfive: jh7110... sashiko-bot
- Re: [PATCH v3 18/19] riscv: dts: starfive: jh7110... Krzysztof Kozlowski
- Re: [PATCH v3 18/19] riscv: dts: starfive: jh... Michal Wilczynski
- [PATCH v3 19/19] MAINTAINERS: Add StarFive JH7110 disp... Michal Wilczynski
- [PATCH v3 17/19] phy: starfive: Add jh7110-inno-hdmi-p... Michal Wilczynski
- [PATCH v3 16/19] phy: rockchip: inno-hdmi: Use the com... Michal Wilczynski
