Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Medium] Missing pinctrl configuration for `vreg_misc_3p3` regulator enable GPIO - [Low] Unused `wcd_default` pinctrl configuration --
commit d71c12fe04485a49b8c9508f6401f49a6f0252e9 Author: Srinivas Kandagatla <[email protected]> arm64: dts: qcom: Add Lenovo ThinkPad T14s Gen 7 Introduce a device tree for the Mahua-based Lenovo ThinkPad T14s Gen 7, a Snapdragon X2 Elite laptop. > diff --git a/arch/arm64/boot/dts/qcom/mahua-lenovo-thinkpad-t14s-gen7.dts > b/arch/arm64/boot/dts/qcom/mahua-lenovo-thinkpad-t14s-gen7.dts > new file mode 100644 > index 0000000000000..be5f12bfe56a4 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/mahua-lenovo-thinkpad-t14s-gen7.dts [ ... ] > + vreg_edp_3p3: regulator-edp-3p3 { > + compatible = "regulator-fixed"; > + > + regulator-name = "VREG_EDP_3P3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + > + gpio = <&tlmm 70 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + > + pinctrl-0 = <&edp_reg_en>; > + pinctrl-names = "default"; > + > + regulator-boot-on; > + }; > + > + vreg_misc_3p3: regulator-misc-3p3 { > + compatible = "regulator-fixed"; > + > + regulator-name = "VREG_MISC_3P3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + > + gpio = <&pmh0110_f_e0_gpios 6 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + > + regulator-boot-on; > + regulator-always-on; > + }; [Severity: Medium] Should vreg_misc_3p3 include pinctrl-0 = <&misc_3p3_reg_en>; and pinctrl-names = "default"; properties? Since the explicit pinctrl state for this GPIO (misc_3p3_reg_en) is defined later in the file but never referenced, omitting it here might cause the PMIC GPIO pad to lack the intended configuration (such as drive-push-pull and power-source). Could this fail to drive the enable pin correctly and leave the I2C touchpad and keyboard unpowered? [ ... ] > +&tlmm { > + gpio-reserved-ranges = <4 4>, /* EC TZ Secure I3C */ > + <10 2>, /* OOB UART */ > + <27 1>, /* TZ trigger */ > + <44 4>, /* TPM */ > + <139 1>; /* TZ trigger */ [ ... ] > + tpad_default: tpad-default-state { > + pins = "gpio3"; > + function = "gpio"; > + bias-disable; > + }; > + > + wcd_default: wcd-reset-n-active-state { > + pins = "gpio191"; > + function = "gpio"; > + drive-strength = <16>; > + bias-disable; > + output-low; > + }; [Severity: Low] Is wcd_default still needed? This pinctrl configuration is defined but never consumed by any device's pinctrl-0 property. Since this board uses WSA8845 and DMICs for audio, it appears a WCD audio codec reset GPIO is not required. Is this a remnant from a reference design that can be removed? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=3
