Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] CONFIG_DRM_PANIC_SCREEN_QR_CODE can be enabled without its source code being compiled. --
commit cfc7923d9a3badf08604fdffe1b2f5534bf2b0b6 Author: Thomas Zimmermann <[email protected]> drm/panic: Move panic display code into helper library This commit moves the panic display code and drm_plane_helper_display_panic_screen() into a new drm_panic_helper.c library. It renames symbols and updates the QR-related code accordingly, linking the object files into the drm_kms_helper module. > diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile > index e635fcffd3790..f0c340aa2ec60 100644 > --- a/drivers/gpu/drm/Makefile > +++ b/drivers/gpu/drm/Makefile [ ... ] > @@ -157,6 +156,8 @@ drm_kms_helper-y := \ > drm_simple_kms_helper.o \ > drm_vblank_helper.o > drm_kms_helper-$(CONFIG_DRM_PANEL_BRIDGE) += bridge/panel.o > +drm_kms_helper-$(CONFIG_DRM_PANIC_HELPER) += drm_panic_helper.o > +drm_kms_helper-$(CONFIG_DRM_PANIC_SCREEN_QR_CODE) += drm_panic_helper_qr.o [Severity: Low] Does this allow CONFIG_DRM_PANIC_SCREEN_QR_CODE to be enabled without its source code being compiled? Since drm_panic_helper_qr.o is now built into drm_kms_helper, if a kernel is configured with CONFIG_DRM_KMS_HELPER=n and CONFIG_DRM_PANIC_SCREEN_QR_CODE=y, the QR code source (drm_panic_helper_qr.rs) will be silently omitted from the build. The definition for CONFIG_DRM_PANIC_SCREEN_QR_CODE in drivers/gpu/drm/Kconfig currently does not depend on or select DRM_KMS_HELPER. Should the Kconfig dependencies be updated to prevent this configuration mismatch? [ ... ] -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=13
