Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Incomplete removal of RDC321x support leaves dead reboot fixups, PCI IDs, and a stale MAINTAINERS entry. --
commit d66c645a0b11af3b988f3b3f1fe1a950247d9884 Author: Arnd Bergmann <[email protected]> mfd: remove unused rdc321x southbridge support This commit removes the rdc321x southbridge support (MFD, GPIO, and Watchdog), as the older i486 chips can no longer boot Linux. > Remove this driver, as there is no way to run Linux any more on the > older chips after i486 support has been removed. > > Signed-off-by: Arnd Bergmann <[email protected]> [Severity: Low] Since the entire platform and driver support is being removed, should we also clean up the remaining dead references to the RDC321x platform? Specifically, the reboot fixup code in arch/x86/kernel/reboot_fixups_32.c has a rdc321x_reset() function and an associated entry in fixups_table that appear to be left behind now that the hardware is no longer supported. Additionally, the PCI_DEVICE_ID_RDC_R6030 definition in include/linux/pci_ids.h is no longer used by any active driver. Finally, there is a stale "RDC R-321X SoC" entry in MAINTAINERS that might need to be removed to complete the cleanup. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=2
