Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] Missing implementation: The commit message claims to add a `static_assert` to `DYNAMIC_DEBUG_CLASSMAP_USE_`, but this change is entirely absent from the patch diff. --
commit 9e868ca8748038075020ceae45f58600f28f51b4 Author: Jim Cromie <[email protected]> dyndbg: harden classmap and descriptor validation This commit improves dynamic debug classmap and descriptor validation by adding run-time overlap checks for used classmaps and scanning module descriptors at load time to warn about missing class IDs. It also adjusts the reporting of unknown class IDs. > - Mirror the compile-time limits of _DEFINE by adding a static_assert > to validate the _offset value passed to DYNAMIC_DEBUG_CLASSMAP_USE_. [Severity: Medium] The commit message explicitly claims this patch mirrors compile-time limits by adding a static_assert for the _offset passed to DYNAMIC_DEBUG_CLASSMAP_USE_. However, this change to include/linux/dynamic_debug.h is entirely missing from the patch diff. It appears this change may have been introduced in an earlier patch in the series (commit ed72477b68f823). Should the commit message be updated to remove this bullet point and avoid confusion? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=34
