Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Moving DECLARE_DYNDBG_CLASSMAP into the CONFIG_DYNAMIC_DEBUG block causes a build failure in DRM when CONFIG_DYNAMIC_DEBUG is disabled but CONFIG_DYNAMIC_DEBUG_CORE is enabled. --
commit 0230d1a17999838bd74e9c3bf428293b96fde5ce Author: Jim Cromie <[email protected]> dyndbg: add stub macro for DECLARE_DYNDBG_CLASSMAP This patch adds a stub macro for DECLARE_DYNDBG_CLASSMAP for !DYNAMIC_DEBUG builds. It moves the original macro definition under the ifdef block to provide a cleaner starting point for future changes. > diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h > index 05743900a1169..a10adac8e8f00 100644 > --- a/include/linux/dynamic_debug.h > +++ b/include/linux/dynamic_debug.h [ ... ] > @@ -314,6 +314,7 @@ void __dynamic_ibdev_dbg(struct _ddebug *descriptor, > > #define DEFINE_DYNAMIC_DEBUG_METADATA(name, fmt) > #define DYNAMIC_DEBUG_BRANCH(descriptor) false > +#define DECLARE_DYNDBG_CLASSMAP(...) [Severity: Low] Does this empty stub cause a build failure in DRM when compiling with CONFIG_DYNAMIC_DEBUG=n, CONFIG_DYNAMIC_DEBUG_CORE=y, and CONFIG_DRM_USE_DYNAMIC_DEBUG=y? Because DYNAMIC_DEBUG_MODULE is missing for drm_print.c in this configuration, the stub macro is used. This causes drm_debug_classes to be undeclared when drm_debug_bitmap() attempts to reference it: drivers/gpu/drm/drm_print.c:drm_debug_bitmap() { ... .map = &drm_debug_classes, ... } Could this empty stub be updated to properly declare the struct pointer even when the debug features are disabled? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=8
