Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [High] Swapped voltage regulators for the DP2 PHY. --
commit be4c87024201f57f02fd6174d5602a08840ba63a Author: Xilin Wu <[email protected]> arm64: dts: qcom: sc8280xp: add Radxa Dragon Q8B This commit adds initial device tree support for the Radxa Dragon Q8B, based on the Qualcomm Snapdragon 8cx Gen 3 SC8280XP platform. It describes various hardware components including storage, PCIe interfaces, USB, HDMI output, and audio. > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-radxa-dragon-q8b.dts > b/arch/arm64/boot/dts/qcom/sc8280xp-radxa-dragon-q8b.dts > new file mode 100644 > index 0000000000000..1c0e94bba4d7d > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-radxa-dragon-q8b.dts [ ... ] > +&mdss0_dp2_phy { > + vdda-phy-supply = <&vreg_l3b>; > + vdda-pll-supply = <&vreg_l6b>; [Severity: High] Are these voltage regulators swapped for the DP2 PHY? vreg_l3b provides 1.2V and vreg_l6b provides 0.88V, but the PHY requires ~0.88V and the PLL requires 1.2V. If vdda-phy-supply receives 1.2V, it violates the physical hardware configuration which expects ~0.88V. This could cause the DP PHY to fail, preventing DisplayPort output, and potentially risk hardware damage due to overvoltage on the PHY rail. > + > + status = "okay"; > +}; -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=6
