Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The commit message inaccurately claims the driver uses `devm_drm_of_get_bridge()`, but it actually uses `devm_drm_panel_bridge_add()`. --
commit fba43756aa0937775cb42a2908c1424721d95003 Author: Luca Ceresoli <[email protected]> drm/bridge: tc358767: select DRM_PANEL_BRIDGE This commit adds the DRM_PANEL_BRIDGE select to the DRM_TOSHIBA_TC358767 Kconfig entry. The commit message justifies this by stating the driver uses a specific bridge function. > This driver uses devm_drm_of_get_bridge(), which is enabled by > DRM_PANEL_BRIDGE. [Severity: Medium] Is the function name in the commit message accurate? Looking at drivers/gpu/drm/bridge/tc358767.c, the driver doesn't seem to call devm_drm_of_get_bridge(). Instead, it calls devm_drm_panel_bridge_add() in tc_probe_dpi_bridge_endpoint(): bridge = devm_drm_panel_bridge_add(dev, panel); And similarly in tc_probe_edp_bridge_endpoint(): panel_bridge = devm_drm_panel_bridge_add(dev, panel); Since devm_drm_panel_bridge_add() is also provided by CONFIG_DRM_PANEL_BRIDGE (as defined in include/drm/drm_bridge.h), the Kconfig change itself appears correct, but the commit message reasoning might be slightly off. Could the commit message be updated to mention devm_drm_panel_bridge_add() instead of devm_drm_of_get_bridge()? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/20260831-drm-bridge-drm_panel-cleanup-v3-0-50efd8168...@bootlin.com?part=10
