29.08.2026 23:14, [email protected] пишет:
Thank you for your contribution! Sashiko AI review found 2 potential issue(s)
to consider:
- [Medium] Commit message and schema description contradict the schema's
compatible list by claiming to only support 'boe,tv101wum-nx0' while silently
including 'boe,tv080wum-nx2'.
- [Medium] The description for `reset-gpios` incorrectly specifies the polarity
as '(active high)', which contradicts the example and typical panel reset
semantics.
--
commit 4949971c710c300054975d637c238b42bc5c2c75
Author: Nickolay Goppen <[email protected]>
dt-bindings: display: panel: Add bindings for Novatek NT51021
This commit introduces device tree bindings for the Novatek NT51021 display
driver IC. It explicitly states support is added for the BOE TV101WUM-NX0
WUXGA video mode panel.
diff --git
a/Documentation/devicetree/bindings/display/panel/novatek,nt51021.yaml
b/Documentation/devicetree/bindings/display/panel/novatek,nt51021.yaml
new file mode 100644
index 0000000000000..a3e4ed10e645d
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/novatek,nt51021.yaml
@@ -0,0 +1,93 @@
[ ... ]
+description: |
+ The NT51021 IC from Novatek is a generic DSI Panel IC used to drive dsi
+ panels.
+ Right now, support is added only for a BOE WUXGA LCD display panels with a
+ resolution of 1200x1920. They are video mode DSI panels.
+
+allOf:
+ - $ref: panel-common.yaml#
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - boe,tv101wum-nx0
+ - boe,tv080wum-nx2
[Severity: Medium]
The commit message and the schema description state that support is added
only for the BOE TV101WUM-NX0 panel, but this adds boe,tv080wum-nx2 to the
compatible list.
Is this regression intended, or should the description and commit message be
updated to reflect support for both panels?
[ ... ]
Will be addressed in v2
+ reg:
+ maxItems: 1
+
+ reset-gpios:
+ maxItems: 1
+ description: phandle of gpio for reset line - This should be 8mA, gpio
+ can be configured using mux, pinctrl, pinctrl-names (active high)
[Severity: Medium]
Could this description cause regressions for users configuring the reset
line?
The text explicitly specifies (active high) for the reset-gpios polarity,
but typical panel semantics and the example block further down use active
low:
reset-gpios = <&tlmm 62 GPIO_ACTIVE_LOW>;
If users follow this text description instead of the example, could they
drive the physical line incorrectly and prevent the panel from initializing?
Will be addressed in v2
--
Best regards,
Nickolay
