> inno_hdmi_bridge_mode_valid() validates the pixel clock against > hdmi->refclk, but that clock is optional and is only present on > platforms that describe a "ref" clock. Platforms where the pixel clock > is produced by a separate device - such as the StarFive JH7110, whose > PHY is both the clock and the PHY provider - have no "ref" clock, so > the check is skipped entirely and every mode is reported as valid. > > A mode the platform cannot generate is then advertised to userspace. > The subsequent modeset appears to succeed, since the atomic enable path > cannot fail, and the display silently stays blank. > > Add a .mode_valid platform operation so platforms can reject modes they > are unable to drive. Platforms that do not implement it are unaffected. > > Signed-off-by: Michal Wilczynski <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=7
