On Sat, Aug 08, 2026 at 10:49:07PM +0800, Guangshuo Li wrote:
> xe_pm_runtime_init() calls pm_runtime_use_autosuspend(), but
> xe_pm_runtime_fini() does not call the matching
> pm_runtime_dont_use_autosuspend() during teardown.
>
> If the autosuspend delay is set to a negative value while autosuspend
> is enabled, the runtime PM core increments usage_count to prevent
> runtime suspend. Without calling pm_runtime_dont_use_autosuspend()
> during teardown, this reference is not dropped.
>
> The documentation for pm_runtime_use_autosuspend() also notes that it
> is important to undo it with pm_runtime_dont_use_autosuspend() at
> driver exit time, unless runtime PM was initially enabled with
> devm_pm_runtime_enable().
>
> Add the missing pm_runtime_dont_use_autosuspend() call to the runtime
> PM teardown path.
>
> This issue was found by manual code inspection.
Thanks for your contribution, but I believe this needs further explanation.
I only see this function getting used in pair with the _enable and _disable
never paierd with _allowed _forbid pair... Why in this case we would need
this?
>
> Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
> Cc: [email protected]
> Signed-off-by: Guangshuo Li <[email protected]>
> ---
> drivers/gpu/drm/xe/xe_pm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
> index 99562f691080..301789adaa21 100644
> --- a/drivers/gpu/drm/xe/xe_pm.c
> +++ b/drivers/gpu/drm/xe/xe_pm.c
> @@ -518,6 +518,7 @@ static void xe_pm_runtime_fini(struct xe_device *xe)
> if (IS_SRIOV_VF(xe))
> return;
>
> + pm_runtime_dont_use_autosuspend(dev);
> pm_runtime_get_sync(dev);
> pm_runtime_forbid(dev);
> }
> --
> 2.43.0
>
