> diff --git a/drivers/gpu/drm/samsung/Kconfig b/drivers/gpu/drm/samsung/Kconfig > new file mode 100644 > index 0000000..34cedda > --- /dev/null > +++ b/drivers/gpu/drm/samsung/Kconfig > @@ -0,0 +1,18 @@ > +config DRM_SAMSUNG > + tristate "DRM Support for Samsung SoC EXYNOS Series" > + depends on DRM && PLAT_SAMSUNG
You should probably also have a default 'm' option? > + select DRM_KMS_HELPER > + select FB_CFB_FILLRECT > + select FB_CFB_COPYAREA > + select FB_CFB_IMAGEBLIT > + select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE > + help > + Choose this option if you have a Samsung SoC EXYNOS chipset. > + If M is selected the module will be called samsungdrm. > + > +config DRM_SAMSUNG_FIMD > + tristate "Samsung DRM FIMD" > + depends on DRM_SAMSUNG > + help > + Choose this option if you want to use Samsung FIMD for DRM. > + If M is selected, the module will be called samsung_drm_fimd .. which is just nitpicking and optional so. I took a look at the code and you can stick 'Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk at oracle.com>' if you want to.
