On Sat, 26 Nov 2011 22:29:12 +0600, Rakib Mullick <rakib.mullick at gmail.com> wrote: > Yes, no real problem with current code. I was just thinking from code > cleanup's pov. Is BUG_ON really needed in i915_add_request() ?
No, just documentation as a reminder that the request should be preallocated, ideally so that we can fail gracefully without touching hardware and leaving it in an inconsistent state wrt to our bookkeeping. (This is more apparent in the overlay code which could hang the chip/driver if we hit a malloc error too late.) The BUG_ON has certainly outlived its usefulness. -Chris -- Chris Wilson, Intel Open Source Technology Centre
