Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The vendor prefix `retroidpocket` used in the new compatible string is not documented in `vendor-prefixes.yaml`. --
--- Patch [1]: [PATCH 1/2] dt-bindings: display: panel: add Ilitek ILI7836A OLED driver --- commit aacb89a0d4e50af14a474c3071ac0dce394b199e Author: Aaron Kling <[email protected]> dt-bindings: display: panel: add Ilitek ILI7836A OLED driver This commit introduces a new device tree binding for the Ilitek ILI7836A OLED driver. It documents the properties and compatible strings required for the MIPI-DSI display used on the Retroid Pocket Nova. > diff --git > a/Documentation/devicetree/bindings/display/panel/ilitek,ili7836a.yaml > b/Documentation/devicetree/bindings/display/panel/ilitek,ili7836a.yaml > new file mode 100644 > index 0000000000000..962cf257ed8d3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili7836a.yaml [ ... ] > +properties: > + compatible: > + items: > + - const: retroidpocket,nova-panel [Severity: Low] Is the retroidpocket vendor prefix documented in vendor-prefixes.yaml? Adding a compatible string with an undocumented vendor prefix will cause a build warning when running make dt_binding_check. > + - const: ilitek,ili7836a > + > + reg: [ ... ] -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
